ZA | May-2025 | Fikiswa Matoti | Form controls #680
Conversation
…descriptive text.
… included its descriptive text.
…cluded its descriptive text.
…t branches in Git.
✅ Deploy Preview for cyf-onboarding-module ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Code is free of error and implementation is quite solid.
-
In the PR description, can you also provide a brief description (under the "Changelist" section) summarizing the purpose of the PR and the changes you’ve made?
-
A PR branch should include only the changes relevant to the specific task or feature it addresses. This branch is created for the Form-Control exercise. As such, it should not include any modified files in the "Wireframe" folder.
Could you revert the changes made in the "Wireframe" folder?
One way to revert the changes is to replace the "Wireframe" folder in this branch by the "Wireframe" folder from themainbranch.- Download the
mainbranch as a ZIP file from https://github.com/FiksMat/Module-Onboarding/tree/main - Delete "Wireframe" folder from this branch
- Copy "Wireframe" folder from the downloaded ZIP file
- Past the folder to this branch
- Commit changes
- Push commit to Github.
- Download the
Form-Controls/index.html
Outdated
| <fieldset> | ||
| <legend><strong>Customer Details</strong></legend><br /> | ||
| <div> | ||
| <label for="firstName" style="margin-right: 10px">First Name:</label> |
There was a problem hiding this comment.
The spec does say "No CSS". You form may not look as nice but can you remove the CSS code?
Form-Controls/index.html
Outdated
| <label for="red"><input type="radio" name="red-grey-black" id="red" value="Red" required />Red</label> | ||
| <label for="grey"><input type="radio" name="red-grey-black" id="grey" value="Grey" required />Grey</label> | ||
| <label for="black"><input type="radio" name="red-grey-black" id="black" value="Black" required />Black</label> | ||
| </fieldset><br /> | ||
| <fieldset> | ||
| <legend><strong>Select your t-shirt size</strong>S</legend> | ||
| <label><input type="radio" name="xs-s-m-l-xl-xxl" id="xs" value="XS" required />XS</label> | ||
| <label><input type="radio" name="xs-s-m-l-xl-xxl" id="s" value="S" required />S</label> | ||
| <label><input type="radio" name="xs-s-m-l-xl-xxl" id="m" value="M" required />M</label> | ||
| <label><input type="radio" name="xs-s-m-l-xl-xxl" id="l" value="L" required />L</label> | ||
| <label><input type="radio" name="xs-s-m-l-xl-xxl" id="xl" value="XL" required />XL</label> | ||
| <label><input type="radio" name="xs-s-m-l-xl-xxl" id="xxl" value="XXL" required />XXL</label> |
There was a problem hiding this comment.
Unusual name for name attributes. I don't think programmer working on this form will appreciate those names.
cjyuan
added
Reviewed
|
Good morning CJ. Thank you for the review. I have updated my code accordingly. Regarding the commit messages from my previous Wireframe PR appearing in the Form Controls PR, I followed the suggested steps, yet they still persist. Despite deleting the old Wireframe PR from GitHub, removing the Module-Onboarding folder from my local machine, and re-cloning it, the issue remains unresolved. |
|
I was referring to the "Wireframe" folder (directory) in my message, nothing to do with the Wireframe PR or Wireframe branch.
|
|
I have replaced the Wireframe folder. |
|
Good job in fixing the branch. You forgot to replace label. Too late now. Better luck in future PRs. |
cjyuan
added
Complete
Learners, PR Template
Self checklist
Changelist
This pull request submits the Form Controls assignment in which I created a form to collect customer data such as personal details, preferred t-shirt color and size.
Questions
Ask any questions you have for your reviewer.